sql: refactor system.namespace calls to use indexes where available #44819
+48
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
namespace_queries
branch
2 times, most recently
from
7e065fa to
3e2c89f
Compare
Refactoring all system.namespace calls such that they always use indexes when querying data if it previously used indexes before. I left `crdb_internal.lookup_namespace_id` as functional as it was before in that it does not lookup anything that isn't a public schema or database. This is because the admin UI only looks up tables into the public schema. Release note: None
otan
force-pushed
the
namespace_queries
branch
from
3e2c89f to
9f884c4
Compare
solongordon
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Reviewed 2 of 8 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @solongordon)
|
bors r=solongordon |
craig bot
pushed a commit
that referenced
this pull request
Feb 10, 2020
44812: tree: modify TimestampTZ operators to use ctx loc for operations r=solongordon a=otan Resolve cockroachdb/django-cockroachdb#54. This PR involves my audit of eval.go and builtins.go to make sure all TimestampTZ operations are performed in the context timezone for TimestampTZ. Results are described in the release note. Important to note we can't parse everything as the current context location, because it can be subject to change mid-session. Release note (bug fix, sql change): Previously, some TimestampTZ operations did not correctly take context timezone (set by `SET TIME ZONE`) into account. This caused a few bugs: * it leads to bugs involving daylight saving in arithmetic, e.g. with `America/Chicago`, evaluating '2010-11-06 23:59:00-05'::timestamptz + '1 day'::interval would return incorrect results as it assumed it was a fixed offset of `-5` instead. * text conversion from timestamptz to string sometimes used the wrong timezone offset if the location of the session does not match the location when the timestamptz was parsed. * to_json builtins with timestamptz does not take session timezone into consideration. These have all been fixed by the PR. 44819: sql: refactor system.namespace calls to use indexes where available r=solongordon a=otan Resolves #44230. Refactoring all system.namespace calls such that they always use indexes when querying data if it previously used indexes before. I left `crdb_internal.lookup_namespace_id` as functional as it was before in that it does not lookup anything that isn't a public schema or database. This is because the admin UI only looks up tables into the public schema. Release note: None Co-authored-by: Oliver Tan <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44230.
Refactoring all system.namespace calls such that they always use indexes
when querying data if it previously used indexes before.
I left
crdb_internal.lookup_namespace_idas functional as it wasbefore in that it does not lookup anything that isn't a public schema
or database. This is because the admin UI only looks up tables into the
public schema.
Release note: None