Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: ensure queries using system.namespace do not degrade with migration #44230

Closed
otan opened this issue Jan 22, 2020 · 1 comment · Fixed by #44819
Closed

sql: ensure queries using system.namespace do not degrade with migration #44230

otan opened this issue Jan 22, 2020 · 1 comment · Fixed by #44819
Assignees
@otan
Labels
C-investigation Further steps needed to qualify. C-label will change. C-performance Perf of queries or internals. Solution not expected to change functional behavior.

Comments

@otan
Copy link
Contributor

otan commented Jan 22, 2020 •
edited
Loading

The index on the system.namespace table changes in 20.1. This involves a change in primary keys.

For example, https://sourcegraph.com/github.com/cockroachdb/cockroach@a309cac09c674728a785f0dcf1702e048719a9bf/-/blob/pkg/sql/privileged_accessor.go#L26:2 is no longer indexed.

We should probably make sure we have a plan for queries no longer have these indexes

Edit: also I think there is a correctness problem here, where temporary tables with the same name as other tables in that particular query will break because they can have the same parentID, name but a different parentSchemaID, hence breaking QueryRow
@otan otan added C-investigation Further steps needed to qualify. C-label will change. C-performance Perf of queries or internals. Solution not expected to change functional behavior. labels Jan 22, 2020
@otan
Copy link
Contributor Author

otan commented Jan 22, 2020

cc @solongordon after our 1:1 discussion today, opening this up to keep track of it.

@otan otan self-assigned this Feb 4, 2020
@otan otan mentioned this issue Feb 6, 2020
Merged
@craig craig bot closed this as completed in 917005b Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otan otan

Labels
C-investigation Further steps needed to qualify. C-label will change. C-performance Perf of queries or internals. Solution not expected to change functional behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: refactor system.namespace calls to use indexes where available otan-cockroach/cockroach
1 participant
@otan