sqlbase: add interesting datums for all scalar types

[rohany]

This PR extends randInterestingDatums to include at least
one interesting datum for all scalar types to ensure that
edge cases don't break things. Additionally, this PR adds
a panic to randInterestingDatums if an interesting datum
for a type could not be found, so that we continue to have
coverage for all of our types.

Part of work for #44322.

Release note: None

[cockroach-teamcity]

This change is 

[yuzefovich]

Reviewed 1 of 2 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rohany and @yuzefovich)

---

pkg/sql/sem/tree/datum.go, line 1485 at r1 (raw file):

}

var DMinUUID = NewDUuid(DUuid{uuid.UUID{}})

These will probably need comments (to satisfy the linter).

---

pkg/sql/sqlbase/testutils.go, line 579 at r1 (raw file):

	specials, ok := randInterestingDatums[typ.Family()]
	if !ok || len(specials) == 0 {
		panic(fmt.Sprintf("no interesting datum for type %s found", typ.String()))

Not all type families are present in the generation, so I think it's not valid to panic here. You could check whether typ is one of scalar types and then panic, or add all families to "interesting families", or not panic at all.

I guess I'd vote for not panicking here.

[rohany]

I think @mjibson wanted to panic here, but maybe checking if it is a scalar type and then panicking is good first step.

[yuzefovich]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rohany)

[rohany]

This seems to have uncovered a bug around TimeTZ! I talked to @otan about it and we'll wait on that fix before merging.

[otan]

fwiw, time is broken too. the problem is the test (and through auditing, cli/dump.go) will parse the special 24 hour time 24:00:00 as 00:00:00. The reason why the test does NOT hit this is because dTimeMax is currently set at 1 microsecond BEFORE 24:00:00.

Filed #44530, will get to it next week.

[rohany]

bors r+

[craig]

Build succeeded

• GitHub CI (Cockroach)