Audit and fix 24:00 handling for Time/TimeTZ #44530
Labels
A-sql-semantics
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Postgres has a unique max time of
24:00:00
for bothTimeTZ
andTime
.They can be stored/parsed as 24:00:00:
But not "added" to '24:00:00':
Our
timeofday
library for parsing time/timetz (timeofday.New
) or inferring time (timeofday.FromInt
) always assumes that we should round -- but there are cases (such ascli/dump.go
) where we should actually NOT round when doing this.We should audit and fix all the cases where rounding is not desired.
This was caught "by accident" in #44459.
The text was updated successfully, but these errors were encountered: