roachtest: attempt to fix cancel test #41032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
Sep 24, 2019
|
LGTM I wonder how hard it is to write a linter for this... |
|
bors r+" |
rafiss
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/cmd/roachtest/cancel.go, line 59 at r1 (raw file):
for _, q := range queries { sem := make(chan struct{}, 1) go func(q string) {
i wonder why q needs to be a param, but t and queryPrefix do not?
rohany
reviewed
Sep 24, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/cancel.go, line 59 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
i wonder why
qneeds to be a param, buttandqueryPrefixdo not?
only things that are "changing" in the loop need to be captured as arguments
Build failed |
There was some suspicious stuff going on in the test, which has been failing - try to fix it in the hopes that next time it'll be more clear what's going on. Release note: None Release justification: test-only change
jordanlewis
force-pushed
the
cancel-test
branch
from
68037fe to
27d2fe4
Compare
|
Oops, used the wrong logger method... bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
41032: roachtest: attempt to fix cancel test r=jordanlewis a=jordanlewis There was some suspicious stuff going on in the test, which has been failing - try to fix it in the hopes that next time it'll be more clear what's going on. Attempt to fix #38417 Release note: None Release justification: test-only change Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some suspicious stuff going on in the test, which has been
failing - try to fix it in the hopes that next time it'll be more clear
what's going on.
Attempt to fix #38417
Release note: None
Release justification: test-only change