Merge #41032

41032: roachtest: attempt to fix cancel test r=jordanlewis a=jordanlewis There was some suspicious stuff going on in the test, which has been failing - try to fix it in the hopes that next time it'll be more clear what's going on. Attempt to fix #38417 Release note: None Release justification: test-only change Co-authored-by: Jordan Lewis <[email protected]>
cockroachdb · Sep 24, 2019 · ded2b6c · ded2b6c
2 parents dfd09f3 + 27d2fe4
commit ded2b6c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/cmd/roachtest/cancel.go b/pkg/cmd/roachtest/cancel.go
@@ -56,8 +56,8 @@ func registerCancel(r *testRegistry) {
 			t.Status("running queries to cancel")
 			for _, q := range queries {
 				sem := make(chan struct{}, 1)
-				go func() {
-					fmt.Printf("executing \"%s\"\n", q)
+				go func(q string) {
+					t.l.Printf("executing \"%s\"\n", q)
 					sem <- struct{}{}
 					_, err := conn.Exec(queryPrefix + q)
 					if err == nil {
@@ -67,7 +67,7 @@ func registerCancel(r *testRegistry) {
 						fmt.Printf("query failed with error: %s\n", err)
 					}
 					sem <- struct{}{}
-				}()
+				}(q)
 
 				<-sem