tree: allow decimals with any number of decimal places #40379
Conversation
Allow decimals of any length, like how Postgres does. This also prevents errors from happening in some cases like division by infinity. relates to cockroachdb#40327 Release note: None
|
This change is |
|
I'm (perhaps baselessly?) worried about performance. I don't know of any good, targeted benchmarks we could use to test this out, but surely there's some decimal SQL benchmarks somewhere in the code that you could try a before/after on? |
|
I'll look around for a benchmark. I'm not sure I understand your concern though -- Also, in the linked issue there was another idea of calling |
I hadn't actually reviewed the code yet - but I thought this was about changing the decimal representation to use unlimited precision behind the scenes, instead of the limited precision that we currently use. Now that I read the diff, I will take my concern back. |
|
thanks for the reviews! bors r+ |
Build failed |
|
bors r+ |
39417: exec: Add framework for vectorized casts. r=rohany a=rohany This PR adds in a framework for performing casts within the vectorized engine, along with a few casts implemented already. Additionally, it implements a randomized testing framework for the cast operators. Fixes #39372 Release note: None 40348: backupccl: deflake TestBackupRestorePartitioned test r=lucy-zhang a=lucy-zhang `TestBackupRestorePartitioned` was flaky because `EXPERIMENTAL_RELOCATE` could fail if there were other replication changes in progress. This PR wraps those statements with `SucceedsSoon()`, following the example of other tests which use `EXPERIMENTAL_RELOCATE`. Closes #39653. Release note: None 40379: tree: allow decimals with any number of decimal places r=rafiss a=rafiss Allow decimals of any length, like how Postgres does. This also prevents errors from happening in some cases like division by infinity. closes #40327 closes #35191 Release note: None Co-authored-by: Rohan Yadav <[email protected]> Co-authored-by: Lucy Zhang <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
Build succeeded |
Allow decimals of any length, like how Postgres does. This also prevents
errors from happening in some cases like division by infinity.
closes #40327
closes #35191
Release note: None