Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec: CastExpr handling for relevant subset of TPCH #39372

Closed
jordanlewis opened this issue Aug 6, 2019 · 1 comment · Fixed by #39417
Closed

exec: CastExpr handling for relevant subset of TPCH #39372

jordanlewis opened this issue Aug 6, 2019 · 1 comment · Fixed by #39417
Assignees
Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@jordanlewis
Copy link
Member

jordanlewis commented Aug 6, 2019

sometimes CastExpr is planned, and we should handle that in vectorized execution.

[email protected]:63701/defaultdb> create table foo (a int8 primary key);
CREATE TABLE

[email protected]:63701/defaultdb> insert into foo values(10);
INSERT 1

[email protected]:63701/defaultdb> select (a/1) from foo;
  ?column?
+----------+
        10
(1 row)

[email protected]:63701/defaultdb> set experimental_vectorize=always;
SET

[email protected]:63701/?> select (a/1) from foo;


E190718 13:42:55.424737 697 sql/distsqlrun/server.go:464  [n1,client=127.0.0.1:63703,user=root] error setting up flow: unable to columnarize render expression "@1::DECIMAL": unhandled projection expression type: *tree.CastExpr
@rohany
Copy link
Contributor

rohany commented Aug 8, 2019

Going through the TPCH queries, it seems like none of them depend on having a cast operator. The blockers seem mainly to be mixed type comparisons.

@awoods187 awoods187 added A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Aug 30, 2019
@craig craig bot closed this as completed in b4caac8 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants