storage: deflake TestReplicaBurstPendingCommandsAndRepropose #38915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#38615. The test was guessing at the min lease applied index that a proposal would be assigned instead of using the index returned from evalAndPropose. Release note: None
|
This change is |
tbg
approved these changes
Jul 17, 2019
There was a problem hiding this comment.
Thanks!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 17, 2019
38915: storage: deflake TestReplicaBurstPendingCommandsAndRepropose r=nvanbenschoten a=nvanbenschoten Fixes #38615. The test was guessing at the min lease applied index that a proposal would be assigned instead of using the index returned from evalAndPropose. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38615.
The test was guessing at the min lease applied index that
a proposal would be assigned instead of using the index
returned from evalAndPropose.
Release note: None