Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamcity: failed test: TestReplicaBurstPendingCommandsAndRepropose #38615

Closed
cockroach-teamcity opened this issue Jul 2, 2019 · 4 comments · Fixed by #38915
Closed

teamcity: failed test: TestReplicaBurstPendingCommandsAndRepropose #38615

cockroach-teamcity opened this issue Jul 2, 2019 · 4 comments · Fixed by #38915
Assignees
@nvanbenschoten
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
19.2

Comments

@cockroach-teamcity
Copy link
Member

The following tests appear to have failed on master (testrace): TestReplicaBurstPendingCommandsAndRepropose

You may want to check for open issues.

#1370661:

TestReplicaBurstPendingCommandsAndRepropose
--- FAIL: testrace/TestReplicaBurstPendingCommandsAndRepropose (0.070s)

------- Stdout: -------
I190702 17:38:30.200110 27478 util/stop/stopper.go:542  quiescing; tasks left:
1      [async] intent_resolver_ir_batcher
1      [async] intent_resolver_gc_batcher
I190702 17:38:30.200409 27478 util/stop/stopper.go:542  quiescing; tasks left:
1      [async] intent_resolver_ir_batcher
    replica_test.go:7511: expected indexes [1 2 3 4 5 6 7 8 9 10], got [5 6 7 8 9 10 1 2 3 4 5 6 7 8 9 10 11 12 13 14]

Please assign, take a look and update the issue accordingly.
@cockroach-teamcity cockroach-teamcity added this to the 19.2 milestone Jul 2, 2019
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jul 2, 2019
@andreimatei
Copy link
Contributor

Andrew, want this one? :)

@ajwerner
Copy link
Contributor

ajwerner commented Jul 8, 2019

I suspect this is related to #38343 but sure.

This was referenced Jul 16, 2019
Closed
Closed
@nvanbenschoten
Copy link
Member

@ajwerner I can take this off your plate.

@ajwerner
Copy link
Contributor

Much appreciated!

nvanbenschoten added a commit to nvanbenschoten/cockroach that referenced this issue Jul 16, 2019
@nvanbenschoten
storage: deflake TestReplicaBurstPendingCommandsAndRepropose
9558144 
Fixes cockroachdb#38615.

The test was guessing at the min lease applied index that
a proposal would be assigned instead of using the index
returned from evalAndPropose.

Release note: None
@nvanbenschoten nvanbenschoten mentioned this issue Jul 16, 2019
Merged
craig bot pushed a commit that referenced this issue Jul 17, 2019
@nvanbenschoten
Merge #38915
c625aba 
38915: storage: deflake TestReplicaBurstPendingCommandsAndRepropose r=nvanbenschoten a=nvanbenschoten

Fixes #38615.

The test was guessing at the min lease applied index that
a proposal would be assigned instead of using the index
returned from evalAndPropose.

Release note: None

Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in #38915 Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
19.2
Development

Successfully merging a pull request may close this issue.

storage: deflake TestReplicaBurstPendingCommandsAndRepropose nvanbenschoten/cockroach
4 participants
@andreimatei @ajwerner @nvanbenschoten @cockroach-teamcity