roachprod: fix nil pointer panic when uploading a key pair #36550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
changed the title
nvanbenschoten
approved these changes
Apr 4, 2019
In cockroachdb#36488 I sloppily snuck in a check to deal with races uploading keys which I clearly did not test. Release note: None
ajwerner
force-pushed
the
ajwerner/fix-silly-nil-panic
branch
from
0b921e5 to
2321108
Compare
Sure, done. |
|
Still LGTM. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 4, 2019
36550: roachprod: fix nil pointer panic when uploading a key pair r=ajwerner a=ajwerner In #36488 I sloppily added in a check to deal with races uploading keys which I clearly did not test. Fixes cause of a skipped AWS test https://teamcity.cockroachdb.com/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=1220242&_focus=4713 from last night. Co-authored-by: Andrew Werner <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #36488 I sloppily added in a check to deal with races uploading keys which I clearly did not test.
Fixes cause of a skipped AWS test https://teamcity.cockroachdb.com/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=1220242&_focus=4713 from last night.