roachprod: enable dns_hostnames in VPC and re-enable terraform config #36488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the missing configuration option from the terraform configuration was using dns hostnames. Now that it's enabled the terraform-created VPCs and associated configuration works with roachtest. This PR fixes the terraform config (which has been applied and tested) and sets it back to the default. Release note: None
|
This change is |
tbg
approved these changes
Apr 3, 2019
Learned my lesson on that one. I'll run it through a brief teamcity test before I bors it but it definitely fixes the problem we saw this morning. |
Release note: None
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 3, 2019
36424: libroach: bump up rocks write-backpressure triggers significantly r=dt a=dt We belive these triggers are unlikely to be hit in normal operation. However they are easy to hit during bulk ingestion of SSTs, as that can quickly add large amounts of data or numbers of files to any given level. When Rocks assumes levels got that way via regular writes getting ahead of the compactor, these triggers then start slowing those writes, affecting foreground traffic that, in reality, is not what hit those triggers. We considered dynamically raising these only durion bulk ingestion, but given that we don't believe they are currently being hit, simply raising them should achieve the same effect without any added complexity. Release note (performance improvement): avoid rocksdb slowing down write traffic during bulk-ingestions. 36488: roachprod: enable dns_hostnames in VPC and re-enable terraform config r=ajwerner a=ajwerner It turns out the missing configuration option from the terraform configuration was using dns hostnames. Now that it's enabled the terraform-created VPCs and associated configuration works with roachtest. This PR fixes the terraform config (which has been applied and tested) and sets it back to the default. Also fixes a broken reference to a renamed terraform output. Release note: None Co-authored-by: David Taylor <[email protected]> Co-authored-by: Andrew Werner <[email protected]>
Build succeeded |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Apr 4, 2019
In cockroachdb#36488 I sloppily snuck in a check to deal with races uploading keys which I clearly did not test. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Apr 4, 2019
36550: roachprod: fix nil pointer panic when uploading a key pair r=ajwerner a=ajwerner In #36488 I sloppily added in a check to deal with races uploading keys which I clearly did not test. Fixes cause of a skipped AWS test https://teamcity.cockroachdb.com/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=1220242&_focus=4713 from last night. Co-authored-by: Andrew Werner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the missing configuration option from the terraform configuration
was using dns hostnames. Now that it's enabled the terraform-created VPCs and
associated configuration works with roachtest. This PR fixes the terraform
config (which has been applied and tested) and sets it back to the default.
Also fixes a broken reference to a renamed terraform output.
Release note: None