Makefile: bump the test timeout #35583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite has progressively become slower and we're now running into the 8m limits, causing lots of test flakes. This new default will bring us forward, but really a more durable solution would be to profile the tests and divide the work among more CI tasks running in parallel. Release note: None
|
This change is |
|
I think this was blocking all the merges today and also causing some nightly flakes. |
This was referenced Mar 9, 2019
nvanbenschoten
approved these changes
Mar 9, 2019
RaduBerinde
approved these changes
Mar 9, 2019
Amen. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 9, 2019
35574: sql: comments in the information_schema definitions r=knz a=knz This removes an irrelevant comment and add references to relevant implementation issues. Release note: None 35583: Makefile: bump the test timeout r=knz a=knz The test suite has progressively become slower and we're now running into the 8m limits, causing lots of test flakes. This new default will bring us forward, but really a more durable solution would be to profile the tests and divide the work among more CI tasks running in parallel. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite has progressively become slower and we're now running
into the 8m limits, causing lots of test flakes.
This new default will bring us forward, but really a more durable
solution would be to profile the tests and divide the work among more
CI tasks running in parallel.
Release note: None