sql: populate information_schema.table_privileges.with_hierarchy #35578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pg doc says: *In the SQL standard, WITH HIERARCHY OPTION is a separate (sub-)privilege allowing certain operations on table inheritance hierarchies. In PostgreSQL, this is included in the SELECT privilege, so this column shows YES if the privilege is SELECT, else NO.* https://www.postgresql.org/docs/9.5/infoschema-table-privileges.html Release note: None
|
This change is |
BramGruneir
approved these changes
Mar 9, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @bobvawter and @mjibson)
|
TFYR! bors r+ |
Build failed (retrying...) |
Build failed (retrying...) |
Build failed |
|
requeue after #35583 |
|
requeue after #35583 merges |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 9, 2019
35573: sql/parser: add a missing contextual help annotation r=knz a=knz Release note: None 35575: sql: fix the match type reporting in information_schema.referential_constraints r=knz a=knz This is the info_schema complement to #35052. Release note (bug fix): CockroachDB now properly reports the composite foreign key match type in `information_schema.referential_constraints`. 35577: sql: properly mark sequences as `bigint` in information_schema.sequences r=knz a=knz Release note (bug fix): CockroachDB now properly reports `bigint` in information_schema.sequences.type, for compatibility with PostgreSQL. 35578: sql: populate information_schema.table_privileges.with_hierarchy r=knz a=knz Pg doc says: *In the SQL standard, WITH HIERARCHY OPTION is a separate (sub-)privilege allowing certain operations on table inheritance hierarchies. In PostgreSQL, this is included in the SELECT privilege, so this column shows YES if the privilege is SELECT, else NO.* https://www.postgresql.org/docs/9.5/infoschema-table-privileges.html Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pg doc says:
In the SQL standard, WITH HIERARCHY OPTION is a
separate (sub-)privilege allowing certain operations on table
inheritance hierarchies. In PostgreSQL, this is included in the SELECT
privilege, so this column shows YES if the privilege is SELECT, else
NO.
https://www.postgresql.org/docs/9.5/infoschema-table-privileges.html
Release note: None