Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: Add a psycopg roachtest #34932

Merged
merged 1 commit into from
Feb 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
249 changes: 249 additions & 0 deletions pkg/cmd/roachtest/psycopg.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,249 @@
// Copyright 2018 The Cockroach Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
// implied. See the License for the specific language governing
// permissions and limitations under the License. See the AUTHORS file
// for names of contributors.

package main

import (
"bufio"
"bytes"
"context"
"fmt"
"regexp"
"sort"
"strings"
"time"

"github.com/cockroachdb/cockroach/pkg/util/retry"
)

var psycopgResultRegex = regexp.MustCompile(`(?P<name>.*) \((?P<class>.*)\) \.\.\. (?P<result>.*)`)

// This test runs psycopg full test suite against an single cockroach node.

func registerPsycopg(r *registry) {
runPsycopg := func(
ctx context.Context,
t *test,
c *cluster,
) {
if c.isLocal() {
t.Fatal("cannot be run in local mode")
}
node := c.Node(1)
t.Status("setting up cockroach")
c.Put(ctx, cockroach, "./cockroach", c.All())
c.Start(ctx, t, c.All())

t.Status("cloning psycopg and installing prerequisites")
opts := retry.Options{
InitialBackoff: 10 * time.Second,
Multiplier: 2,
MaxBackoff: 5 * time.Minute,
}
for attempt, r := 0, retry.StartWithCtx(ctx, opts); r.Next(); {
if ctx.Err() != nil {
return
}
if c.t.Failed() {
return
}
attempt++

c.l.Printf("attempt %d - update dependencies", attempt)
if err := c.RunE(ctx, node, `sudo apt-get -q update`); err != nil {
continue
}
if err := c.RunE(
ctx, node, `sudo apt-get -qy install make python3 libpq-dev python-dev gcc`,
); err != nil {
continue
}

c.l.Printf("attempt %d - cloning psycopg", attempt)
if err := c.RunE(ctx, node, `rm -rf /mnt/data1/psycopg`); err != nil {
continue
}
if err := c.GitCloneE(
ctx,
"https://github.com/psycopg/psycopg2.git",
"/mnt/data1/psycopg",
"2_7_7",
node,
); err != nil {
continue
}

break
}

t.Status("building psycopg")
for attempt, r := 0, retry.StartWithCtx(ctx, opts); r.Next(); {
if ctx.Err() != nil {
return
}
if c.t.Failed() {
return
}
attempt++
c.l.Printf("attempt %d - building psycopg", attempt)
if err := c.RunE(
ctx, node, `cd /mnt/data1/psycopg/ && make`,
); err != nil {
continue
}
break
}

version, err := fetchCockroachVersion(ctx, c, node[0])
if err != nil {
t.Fatal(err)
}
blacklistName, expectedFailures := getPsycopgBlacklistForVersion(version)
if expectedFailures == nil {
t.Fatalf("No psycopg blacklist defined for cockroach version %s", version)
}
c.l.Printf("Running cockroach version %s, using blacklist %s", version, blacklistName)

t.Status("running psycopg test suite")
// Note that this is expected to return an error, since the test suite
// will fail. And it is safe to swallow it here.
rawResults, _ := c.RunWithBuffer(ctx, t.l, node,
`cd /mnt/data1/psycopg/ &&
export PSYCOPG2_TESTDB=defaultdb &&
export PSYCOPG2_TESTDB_USER=root &&
export PSYCOPG2_TESTDB_PORT=26257 &&
export PSYCOPG2_TESTDB_HOST=localhost &&
make check`,
)

t.Status("collating the test results")
c.l.Printf("Test Results: %s", rawResults)

// Find all the failed and errored tests.

var failUnexpectedCount, failExpectedCount int
var passUnexpectedCount, passExpectedCount, notRunCount int
// Put all the results in a giant map of [testname]result
results := make(map[string]string)
// Current failures are any tests that reported as failed, regardless of if
// they were expected or not.
var currentFailures, allTests []string
runTests := make(map[string]struct{})

scanner := bufio.NewScanner(bytes.NewReader(rawResults))
for scanner.Scan() {
match := psycopgResultRegex.FindStringSubmatch(scanner.Text())
if match != nil {
groups := map[string]string{}
for i, name := range match {
groups[psycopgResultRegex.SubexpNames()[i]] = name
}
test := fmt.Sprintf("%s.%s", groups["class"], groups["name"])
pass := groups["result"] == "ok"
allTests = append(allTests, test)
issue, expectedFailure := expectedFailures[test]

switch {
case pass && !expectedFailure:
results[test] = fmt.Sprintf("--- PASS: %s (expected)", test)
passExpectedCount++
case pass && expectedFailure:
results[test] = fmt.Sprintf("--- PASS: %s - %s (unexpected)",
test, maybeAddGithubLink(issue),
)
passUnexpectedCount++
case !pass && expectedFailure:
results[test] = fmt.Sprintf("--- FAIL: %s - %s (expected)",
test, maybeAddGithubLink(issue),
)
failExpectedCount++
currentFailures = append(currentFailures, test)
case !pass && !expectedFailure:
results[test] = fmt.Sprintf("--- FAIL: %s (unexpected)", test)
failUnexpectedCount++
currentFailures = append(currentFailures, test)
}
runTests[test] = struct{}{}
}
}

// Collect all the tests that were not run.
for test, issue := range expectedFailures {
if _, ok := runTests[test]; ok {
continue
}
allTests = append(allTests, test)
results[test] = fmt.Sprintf("--- FAIL: %s - %s (not run)", test, maybeAddGithubLink(issue))
notRunCount++
}

// Log all the test results. We re-order the tests alphabetically here
// to ensure that we're doing .
sort.Strings(allTests)
for _, test := range allTests {
result, ok := results[test]
if !ok {
t.Fatalf("can't find %s in test result list", test)
}
t.l.Printf("%s\n", result)
}

t.l.Printf("------------------------\n")

var bResults strings.Builder
fmt.Fprintf(&bResults, "Tests run on Cockroach %s\n", version)
fmt.Fprintf(&bResults, "%d Total Tests Run\n",
passExpectedCount+passUnexpectedCount+failExpectedCount+failUnexpectedCount,
)
fmt.Fprintf(&bResults, "%d tests passed\n", passUnexpectedCount+passExpectedCount)
fmt.Fprintf(&bResults, "%d tests failed\n", failUnexpectedCount+failExpectedCount)
fmt.Fprintf(&bResults, "%d tests passed unexpectedly\n", passUnexpectedCount)
fmt.Fprintf(&bResults, "%d tests failed unexpectedly\n", failUnexpectedCount)
fmt.Fprintf(&bResults, "%d tests expected failed, but not run \n", notRunCount)
fmt.Fprintf(&bResults, "For a full summary look at the logs. \n")
t.l.Printf("%s\n", bResults.String())
t.l.Printf("------------------------\n")

if failUnexpectedCount > 0 || passUnexpectedCount > 0 || notRunCount > 0 {
// Create a new psycopg_blacklist so we can easily update this test.
sort.Strings(currentFailures)
var b strings.Builder
fmt.Fprintf(&b, "Here is new psycopg blacklist that can be used to update the test:\n\n")
fmt.Fprintf(&b, "var %s = blacklist{\n", blacklistName)
for _, test := range currentFailures {
issue := expectedFailures[test]
if len(issue) == 0 {
issue = "unknown"
}
fmt.Fprintf(&b, " \"%s\": \"%s\",\n", test, issue)
}
fmt.Fprintf(&b, "}\n\n")
t.l.Printf("\n\n%s\n\n", b.String())
t.l.Printf("------------------------\n")
t.Fatalf("\n%s\nAn updated blacklist (%s) is available in the logs\n",
bResults.String(),
blacklistName,
)
}
}

r.Add(testSpec{
Name: "psycopg",
Cluster: makeClusterSpec(1),
Run: func(ctx context.Context, t *test, c *cluster) {
runPsycopg(ctx, t, c)
},
})
}
Loading