roachtest: Add a psycopg roachtest #34932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This roachtest is similar to the hibernate roachtest and tests the driver used in SQLAlchamy. Release note: None
|
This change is |
knz
reviewed
Feb 15, 2019
There was a problem hiding this comment.
Test structure LGTM but I'd like us to sit together and review all the missing issue links.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @BramGruneir)
pkg/cmd/roachtest/psycopg_blacklist.go, line 90 at r1 (raw file):
"psycopg2.tests.test_cancel.CancelTests.test_cancel": "5807", "psycopg2.tests.test_cancel.CancelTests.test_empty_cancel": "5807", "psycopg2.tests.test_connection.AutocommitTests.test_set_session_autocommit": "unknown",
I think we should review these together and add the missing issue links.
|
TFTR and of course! I plan to break it down similar to how we handled the hibernate test. That work can be done as a follow up. In this case, I just populated the ones where our error message already contained the issue. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 15, 2019
34932: roachtest: Add a psycopg roachtest r=BramGruneir a=BramGruneir This roachtest is similar to the hibernate roachtest and tests the driver used in SQLAlchamy. Release note: None Co-authored-by: Bram Gruneir <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This roachtest is similar to the hibernate roachtest and tests the driver
used in SQLAlchamy.
Release note: None