roachtest: fail YCSB for debugging if below performance expectations #34808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @nvanbenschoten)
pkg/cmd/roachtest/ycsb.go, line 106 at r1 (raw file):
name = fmt.Sprintf("ycsb/%s/nodes=3/cpu=%d", wl, cpus) } wl, cpus := wl, cpus
Were we messing this up before with cpus? Yikes.
ajwerner
commented
Feb 12, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/ycsb.go, line 106 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Were we messing this up before with
cpus? Yikes.
No, it wasn't captured by the closure before.
There was a problem hiding this comment.
Still LGTM
Reviewable status:
pkg/cmd/roachtest/ycsb.go, line 106 at r1 (raw file):
Previously, ajwerner wrote…
No, it wasn't captured by the closure before.
Oh, right. 👍
This PR is a temporary measure to aid in debugging the very peculiar cockroachdb#34458. The idea is that if a run fails to meet the expected throughput (which is above but near the bad runs), we'd like the opportunity to poke around. Release note: None
ajwerner
force-pushed
the
ajwerner/fail-on-bad-perf-for-ycsb
branch
from
5a01291 to
c4c3717
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 12, 2019
34808: roachtest: fail YCSB for debugging if below performance expectations r=ajwerner a=ajwerner This PR is a temporary measure to aid in debugging the very peculiar #34458. The idea is that if a run fails to meet the expected throughput (which is above but near the bad runs), we'd like the opportunity to poke around. Release note: None Co-authored-by: Andrew Werner <[email protected]>
Build succeeded |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Mar 2, 2019
These performance expectations were added in cockroachdb#34808 to help debug confusing results where performance would regress dramatically. That behavior was due to branches for old release versions with lower performance being run in CI and uploading their results to the same place as new versions. The unfortunate consequence of this change is that old versions can no longer pass these tests. Now that the mystery has been solved, this PR removes those performance checks. Fixes cockroachdb#35332. Fixes cockroachdb#35331. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 4, 2019
35334: roachtest: remove ycsb performance expectations r=ajwerner a=ajwerner These performance expectations were added in #34808 to help debug confusing results where performance would regress dramatically. That behavior was due to branches for old release versions with lower performance being run in CI and uploading their results to the same place as new versions. The unfortunate consequence of this change is that old versions can no longer pass these tests. Now that the mystery has been solved, this PR removes those performance checks. Fixes #35332. Fixes #35331. Release note: None Co-authored-by: Andrew Werner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a temporary measure to aid in debugging the very peculiar #34458.
The idea is that if a run fails to meet the expected throughput (which is above
but near the bad runs), we'd like the opportunity to poke around.
Release note: None