Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: ycsb/A/nodes=3 failed #35331

Closed
cockroach-teamcity opened this issue Mar 2, 2019 · 2 comments
Closed

roachtest: ycsb/A/nodes=3 failed #35331

cockroach-teamcity opened this issue Mar 2, 2019 · 2 comments
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/f28aa78febc98911122254a9d3c8212c0c940e08

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
stdbuf -oL -eL \
make stressrace TESTS=ycsb/A/nodes=3 PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1158899&tab=buildLog

The test failed on release-2.1:
	cluster.go:1585,ycsb.go:89,ycsb.go:110,test.go:1211: ycsb/A/nodes=3 failed to meet throughput expectations: observed 2000, expected at least 498.3

@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. labels Mar 2, 2019
@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/f28aa78febc98911122254a9d3c8212c0c940e08

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
stdbuf -oL -eL \
make stressrace TESTS=ycsb/A/nodes=3 PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1158895&tab=buildLog

The test failed on release-2.1:
	cluster.go:1585,ycsb.go:89,ycsb.go:110,test.go:1211: ycsb/A/nodes=3 failed to meet throughput expectations: observed 2000, expected at least 371.3

@petermattis
Copy link
Collaborator

@ajwerner Looks like the failure message has expected and observed reversed. This failure is on 2.1. I believe the lower throughput is expected. Now that you've figured out the cause of the throughput drops on roachperf, perhaps we should just get rid of this minimal throughput check. The alternative is to provide different threshold values per release.

ajwerner added a commit to ajwerner/cockroach that referenced this issue Mar 2, 2019
These performance expectations were added in cockroachdb#34808 to help debug confusing
results where performance would regress dramatically. That behavior was due
to branches for old release versions with lower performance being run in CI
and uploading their results to the same place as new versions. The unfortunate
consequence of this change is that old versions can no longer pass these tests.
Now that the mystery has been solved, this PR removes those performance checks.

Fixes cockroachdb#35332.
Fixes cockroachdb#35331.

Release note: None
craig bot pushed a commit that referenced this issue Mar 4, 2019
35334: roachtest: remove ycsb performance expectations r=ajwerner a=ajwerner

These performance expectations were added in #34808 to help debug confusing
results where performance would regress dramatically. That behavior was due
to branches for old release versions with lower performance being run in CI
and uploading their results to the same place as new versions. The unfortunate
consequence of this change is that old versions can no longer pass these tests.
Now that the mystery has been solved, this PR removes those performance checks.

Fixes #35332.
Fixes #35331.

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in #35334 Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Development

No branches or pull requests

3 participants