-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: ycsb/A/nodes=3 failed #35331
Comments
SHA: https://github.com/cockroachdb/cockroach/commits/f28aa78febc98911122254a9d3c8212c0c940e08 Parameters: To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1158895&tab=buildLog
|
@ajwerner Looks like the failure message has expected and observed reversed. This failure is on 2.1. I believe the lower throughput is expected. Now that you've figured out the cause of the throughput drops on roachperf, perhaps we should just get rid of this minimal throughput check. The alternative is to provide different threshold values per release. |
These performance expectations were added in cockroachdb#34808 to help debug confusing results where performance would regress dramatically. That behavior was due to branches for old release versions with lower performance being run in CI and uploading their results to the same place as new versions. The unfortunate consequence of this change is that old versions can no longer pass these tests. Now that the mystery has been solved, this PR removes those performance checks. Fixes cockroachdb#35332. Fixes cockroachdb#35331. Release note: None
35334: roachtest: remove ycsb performance expectations r=ajwerner a=ajwerner These performance expectations were added in #34808 to help debug confusing results where performance would regress dramatically. That behavior was due to branches for old release versions with lower performance being run in CI and uploading their results to the same place as new versions. The unfortunate consequence of this change is that old versions can no longer pass these tests. Now that the mystery has been solved, this PR removes those performance checks. Fixes #35332. Fixes #35331. Release note: None Co-authored-by: Andrew Werner <[email protected]>
SHA: https://github.com/cockroachdb/cockroach/commits/f28aa78febc98911122254a9d3c8212c0c940e08
Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1158899&tab=buildLog
The text was updated successfully, but these errors were encountered: