storage: test raft log decision input's MaxLogSize #34285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See cockroachdb#34284. Release note: None
|
This change is |
petermattis
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @petermattis)
|
bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Jan 28, 2019
34280: util: fix NoCopy on go1.11 and later r=RaduBerinde a=petermattis Vet now requires that `NoCopy` structure has both `Lock` and `Unlock` methods. Fixes #34278 Release note: None 34285: storage: test raft log decision input's MaxLogSize r=petermattis a=tbg See #34284. Release note: None Co-authored-by: Peter Mattis <[email protected]> Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #34284.
Release note: None