util: NoCopy no longer works #34278
Labels
A-testing
Testing tools and infrastructure
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
S-3-productivity
Severe issues that impede the productivity of CockroachDB developers.
Comments
knz
added
C-bug
|
cc @petermattis |
petermattis
added a commit
to petermattis/cockroach
that referenced
this issue
Jan 28, 2019
Vet now requires that `NoCopy` structure has both `Lock` and `Unlock` methods. Name `NoCopy` members with an underscore. This avoids a (new?) warning about these members being unused. Fixes cockroachdb#34278 Release note: None
craig bot
pushed a commit
that referenced
this issue
Jan 28, 2019
34280: util: fix NoCopy on go1.11 and later r=RaduBerinde a=petermattis Vet now requires that `NoCopy` structure has both `Lock` and `Unlock` methods. Fixes #34278 Release note: None 34285: storage: test raft log decision input's MaxLogSize r=petermattis a=tbg See #34284. Release note: None Co-authored-by: Peter Mattis <[email protected]> Co-authored-by: Tobias Schottdorf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
util.NoCopy is supposed to trigger the linter on by-value copies. I put it in a structure and had no problem doing
copy := *x.The text was updated successfully, but these errors were encountered: