storage: ensure kv.bulk_io_write settings are positive #31572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Oct 18, 2018
|
Your release note has an extra verb doesn't sound quite right. :) |
|
I think the export limit needs the same treatment, as it is also used to configure one of these semaphores |
Fixes #31571 Release note (bug fix): fix a panic when setting some kv.bulk_io_write settings to a value < 1
maddyblue
changed the title
|
Updated to support export too |
dt
approved these changes
Oct 18, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 18, 2018
31572: storage: ensure kv.bulk_io_write settings are positive r=mjibson a=mjibson Fixes #31571 Release note (bug fix): fix a panic when setting some kv.bulk_io_write settings to a value < 1 Co-authored-by: Matt Jibson <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31571
Release note (bug fix): fix a panic when setting some kv.bulk_io_write
settings to a value < 1