Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: panic: set kv.bulk_io_write.concurrent_import_requests to < 1 #31571

Closed
maddyblue opened this issue Oct 18, 2018 · 1 comment · Fixed by #31572
Closed

sql: panic: set kv.bulk_io_write.concurrent_import_requests to < 1 #31571

maddyblue opened this issue Oct 18, 2018 · 1 comment · Fixed by #31572
Assignees
@dt @maddyblue
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@maddyblue
Copy link
Contributor

set cluster setting kv.bulk_io_write.concurrent_import_requests = 0 causes a panic
@maddyblue maddyblue added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Oct 18, 2018
@maddyblue maddyblue mentioned this issue Oct 18, 2018
Merged
@maddyblue
Copy link
Contributor Author

This is a pretty bad bug because IF a user ever did this, the actual setting of the value succeeds and is persisted to the database. It then panics when trying to change the value in the semaphore. When cockroach starts back up it immediately panics again. This means if a user ever did this their database would be unstartable (even after applying #31572).

A more full fix may be to change the setting code to use the default value if the value in the setting at startup doesn't pass validation.

craig bot pushed a commit that referenced this issue Oct 18, 2018
@maddyblue
Merge #31572
6e7ed1b 
31572: storage: ensure kv.bulk_io_write settings are positive r=mjibson a=mjibson

Fixes #31571

Release note (bug fix): fix a panic when setting some kv.bulk_io_write
settings to a value < 1

Co-authored-by: Matt Jibson <[email protected]>
@craig craig bot closed this as completed in #31572 Oct 18, 2018
@maddyblue maddyblue mentioned this issue Oct 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dt dt

@maddyblue maddyblue

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: ensure kv.bulk_io_write settings are positive
2 participants
@dt @maddyblue