sql: attempt to deflake distsql physical planner tests #31239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the range cache is populated before verifying things about it. Release note: None
|
This change is |
|
Yep, this fixes the flake. Just verified it. |
tbg
approved these changes
Oct 11, 2018
This was referenced Oct 11, 2018
|
Pretty flaky, I'm going to merge this bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 11, 2018
30913: server: add a configuration to enable GC of system.rangelog r=tschottdorf a=mvijaykarthik system.rangelog table currently grows unboundedly. The rate of growth is slow (as long as there is no replica rebalancing thrashing), but it can still become a problem in long running clusters. This commit adds cluster settings to specify interval and TTL for rows in system.rangelog. By default, TTL of system.rangelog is set to 30 days. Fixes #21260 Release note: Add configuration to enable GC of system.rangelog 31239: sql: attempt to deflake distsql physical planner tests r=tschottdorf a=jordanlewis Make sure the range cache is populated before verifying things about it. This seems like a hack, but otherwise I think these will just keep flaking. Closes #25808. Closes #31235. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]> Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Oct 11, 2018
31285: backport-2.1: sql: attempt to deflake distsql physical planner tests r=jordanlewis a=tschottdorf Backport 1/1 commits from #31239. Flaky as hell on release-2.1. Someone please ~~bors~~merge this for me with the LGTM. /cc @cockroachdb/release --- Make sure the range cache is populated before verifying things about it. This seems like a hack, but otherwise I think these will just keep flaking. Closes #25808. Closes #31235. Release note: None Co-authored-by: Jordan Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the range cache is populated before verifying things about it.
This seems like a hack, but otherwise I think these will just keep flaking.
Closes #25808.
Closes #31235.
Release note: None