-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teamcity: failed tests on master: testrace/TestDistSQLRangeCachesIntegrationTest #25808
Comments
Attempts to reproduce this on a |
Still haven't managed to reproduce this. So it seems that this test is testing that misplanned The flakiness in this test could be fixed by verifying data placement before running the first query. |
RELOCATE is supposed to return only after things have been relocated. We have various logic tests that rely on this: https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/logictest/testdata/planner_test/distsql_agg#L14 CCing @tschottdorf @a-robinson who might know of some caveats here. Also CC @m-schneider who was asking the same thing. |
Also see #31068. |
Sorry for missing this. The |
Seems like this is the way to go. |
30913: server: add a configuration to enable GC of system.rangelog r=tschottdorf a=mvijaykarthik system.rangelog table currently grows unboundedly. The rate of growth is slow (as long as there is no replica rebalancing thrashing), but it can still become a problem in long running clusters. This commit adds cluster settings to specify interval and TTL for rows in system.rangelog. By default, TTL of system.rangelog is set to 30 days. Fixes #21260 Release note: Add configuration to enable GC of system.rangelog 31239: sql: attempt to deflake distsql physical planner tests r=tschottdorf a=jordanlewis Make sure the range cache is populated before verifying things about it. This seems like a hack, but otherwise I think these will just keep flaking. Closes #25808. Closes #31235. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]> Co-authored-by: Jordan Lewis <[email protected]>
31285: backport-2.1: sql: attempt to deflake distsql physical planner tests r=jordanlewis a=tschottdorf Backport 1/1 commits from #31239. Flaky as hell on release-2.1. Someone please ~~bors~~merge this for me with the LGTM. /cc @cockroachdb/release --- Make sure the range cache is populated before verifying things about it. This seems like a hack, but otherwise I think these will just keep flaking. Closes #25808. Closes #31235. Release note: None Co-authored-by: Jordan Lewis <[email protected]>
The following tests appear to have failed:
#672666:
Please assign, take a look and update the issue accordingly.
The text was updated successfully, but these errors were encountered: