log: minor copyedits to fatal error postamble #30918
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/util/log/clog.go, line 63 at r1 (raw file):
Please submit a crash report by following the instructions here: https://github.com/cockroachdb/cockroach/issues/new?template=bug_report.md
I intentionally didn't hard-code the template here. We're releasing this, and we might change the template, which drops users into a void instead: https://github.com/cockroachdb/cockroach/issues/new?template=bug_report_nope.md
I had a similar thought. What if we added a lint that the template must exist? OTOH, we could make a shortlink that redirects here and then we're insulated if it needs to change to anything else, too... |
There was a problem hiding this comment.
I personally would KISS here (the funnel will break as people fudge with the log files and realize they don't have a black hole to through them in, etc) but a lint sounds OK too. The shortlink option adds another link that can break so I'd rather not follow that direction.
Reviewable status:
Release note: None
couchand
force-pushed
the
edit/fatal-error-postamble
branch
from
8f5fd84 to
ceacfc1
Compare
|
Exactly right on the funnel: trying to remove a click was to shorten it. Going with your original link for now to keep it simple. The choose page also feels more like a landing page, whereas the bug report template itself is another big wall of text to parse, good to have a moment in between them. |
|
bors r=tschottdorf |
30918: log: minor copyedits to fatal error postamble r=tschottdorf a=couchand A followup to #30898 with a few minor edits. Co-authored-by: Andrew Couch <[email protected]>
|
Thanks @couchand. I'll backport my change and slap this on top of it. |
Build succeeded |
A followup to #30898 with a few minor edits.