log: include a call to action with fatal errors #30898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
When rare errors happen in the wild, they are a) often unreported or b) reported only in anonymized form, with little context that can help pinpoint the root cause. Users can help us out tremendously by contacting us, and so we should incentivize that. Do so by concluding fatal errors (i.e. most crashes) with a call to action. Touches cockroachdb#28699. Touches cockroachdb#24033. Touches cockroachdb#25173. Release note: None
tbg
force-pushed
the
fix/fatal-feedback
branch
from
41da4d0 to
ff6d5fc
Compare
|
LGTM
Good idea!
…On Wed, Oct 3, 2018 at 8:38 AM kena ***@***.***> wrote:
***@***.**** approved this pull request.
wow, solid
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#30898 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF6f963isfTib8Tnmy-VjFr67C8OxYcpks5uhK-qgaJpZM4XExu1>
.
|
|
bors r=knz,petermattis TFTRs! |
craig bot
pushed a commit
that referenced
this pull request
Oct 3, 2018
30898: log: include a call to action with fatal errors r=knz,petermattis a=tschottdorf When rare errors happen in the wild, they are a) often unreported or b) reported only in anonymized form, with little context that can help pinpoint the root cause. Users can help us out tremendously by contacting us, and so we should incentivize that. Do so by concluding fatal errors (i.e. most crashes) with a call to action. Touches #28699. Touches #24033. Touches #25173. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Oct 3, 2018
30918: log: minor copyedits to fatal error postamble r=tschottdorf a=couchand A followup to #30898 with a few minor edits. Co-authored-by: Andrew Couch <[email protected]>
This was referenced Oct 3, 2018
|
Great call - thanks @tschottdorf ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rare errors happen in the wild, they are a) often unreported or b)
reported only in anonymized form, with little context that can help
pinpoint the root cause.
Users can help us out tremendously by contacting us, and so we should
incentivize that.
Do so by concluding fatal errors (i.e. most crashes) with a call to
action.
Touches #28699.
Touches #24033.
Touches #25173.
Release note: None