Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: relax space reclamation in drop test #29511

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

tbg
Copy link
Member

@tbg tbg commented Sep 4, 2018

We know it fails; we are not looking into it right now due to other priorities.
This should be investigated and fixed in the course of #29290.

Closes #29232.
Closes #29327.

Release note: None

We know it fails; we are not looking into it right now due to other priorities.
This should be investigated and fixed in the course of cockroachdb#29290.

Closes cockroachdb#29232.
Closes cockroachdb#29327.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@tbg
Copy link
Member Author

tbg commented Sep 4, 2018

bors r=petermattis

@craig
Copy link
Contributor

craig bot commented Sep 4, 2018

Build failed

@tbg
Copy link
Member Author

tbg commented Sep 4, 2018

Failed in TestSQLAlchemy.

bors r=petermattis

craig bot pushed a commit that referenced this pull request Sep 4, 2018
29444: changefeedccl: resurrect changefeed benchmark r=mrtracy a=danhhz

    name                           time/op
    ChangefeedTicks/InitialScan-8    12.3ms ± 3%
    ChangefeedTicks/SteadyState-8    52.3ms ± 3%

    name                           speed
    ChangefeedTicks/InitialScan-8  11.6MB/s ± 3%
    ChangefeedTicks/SteadyState-8  2.73MB/s ± 3%

    name                           alloc/op
    ChangefeedTicks/InitialScan-8    2.08MB ± 0%
    ChangefeedTicks/SteadyState-8    5.37MB ± 0%

    name                           allocs/op
    ChangefeedTicks/InitialScan-8     35.1k ± 0%
    ChangefeedTicks/SteadyState-8     68.6k ± 0%

Release note: None

29470: roachtest: add acceptance/version-upgrade r=nvanbenschoten a=petermattis

Move the version-upgrade acceptance test to a new
acceptance/version-upgrade roachtest.

See #29151

Release note: None

29511: roachtest: relax space reclamation in drop test r=petermattis a=tschottdorf

We know it fails; we are not looking into it right now due to other priorities.
This should be investigated and fixed in the course of #29290.

Closes #29232.
Closes #29327.

Release note: None

Co-authored-by: Daniel Harrison <[email protected]>
Co-authored-by: Peter Mattis <[email protected]>
Co-authored-by: Tobias Schottdorf <[email protected]>
@craig
Copy link
Contributor

craig bot commented Sep 4, 2018

Build succeeded

@craig craig bot merged commit 0e5efdb into cockroachdb:master Sep 4, 2018
@tbg tbg deleted the roachtest/skip-drop branch September 21, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants