-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: relax space reclamation in drop test #29511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know it fails; we are not looking into it right now due to other priorities. This should be investigated and fixed in the course of cockroachdb#29290. Closes cockroachdb#29232. Closes cockroachdb#29327. Release note: None
petermattis
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale)
bors r=petermattis |
Build failed |
Failed in bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Sep 4, 2018
29444: changefeedccl: resurrect changefeed benchmark r=mrtracy a=danhhz name time/op ChangefeedTicks/InitialScan-8 12.3ms ± 3% ChangefeedTicks/SteadyState-8 52.3ms ± 3% name speed ChangefeedTicks/InitialScan-8 11.6MB/s ± 3% ChangefeedTicks/SteadyState-8 2.73MB/s ± 3% name alloc/op ChangefeedTicks/InitialScan-8 2.08MB ± 0% ChangefeedTicks/SteadyState-8 5.37MB ± 0% name allocs/op ChangefeedTicks/InitialScan-8 35.1k ± 0% ChangefeedTicks/SteadyState-8 68.6k ± 0% Release note: None 29470: roachtest: add acceptance/version-upgrade r=nvanbenschoten a=petermattis Move the version-upgrade acceptance test to a new acceptance/version-upgrade roachtest. See #29151 Release note: None 29511: roachtest: relax space reclamation in drop test r=petermattis a=tschottdorf We know it fails; we are not looking into it right now due to other priorities. This should be investigated and fixed in the course of #29290. Closes #29232. Closes #29327. Release note: None Co-authored-by: Daniel Harrison <[email protected]> Co-authored-by: Peter Mattis <[email protected]> Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know it fails; we are not looking into it right now due to other priorities.
This should be investigated and fixed in the course of #29290.
Closes #29232.
Closes #29327.
Release note: None