Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: resurrect changefeed benchmark #29444

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Aug 31, 2018

name                           time/op
ChangefeedTicks/InitialScan-8    12.3ms ± 3%
ChangefeedTicks/SteadyState-8    52.3ms ± 3%

name                           speed
ChangefeedTicks/InitialScan-8  11.6MB/s ± 3%
ChangefeedTicks/SteadyState-8  2.73MB/s ± 3%

name                           alloc/op
ChangefeedTicks/InitialScan-8    2.08MB ± 0%
ChangefeedTicks/SteadyState-8    5.37MB ± 0%

name                           allocs/op
ChangefeedTicks/InitialScan-8     35.1k ± 0%
ChangefeedTicks/SteadyState-8     68.6k ± 0%

Release note: None

@danhhz danhhz requested review from mrtracy and a team August 31, 2018 20:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

    name                           time/op
    ChangefeedTicks/InitialScan-8    12.3ms ± 3%
    ChangefeedTicks/SteadyState-8    52.3ms ± 3%

    name                           speed
    ChangefeedTicks/InitialScan-8  11.6MB/s ± 3%
    ChangefeedTicks/SteadyState-8  2.73MB/s ± 3%

    name                           alloc/op
    ChangefeedTicks/InitialScan-8    2.08MB ± 0%
    ChangefeedTicks/SteadyState-8    5.37MB ± 0%

    name                           allocs/op
    ChangefeedTicks/InitialScan-8     35.1k ± 0%
    ChangefeedTicks/SteadyState-8     68.6k ± 0%

Release note: None
@danhhz
Copy link
Contributor Author

danhhz commented Sep 3, 2018

TFTR!

bors r=mrtracy

@craig
Copy link
Contributor

craig bot commented Sep 3, 2018

Build failed

@danhhz
Copy link
Contributor Author

danhhz commented Sep 4, 2018

TestSQLAlchemy and acceptance/status-server (local roachtest) flaked

bors r=mrtracy

craig bot pushed a commit that referenced this pull request Sep 4, 2018
29444: changefeedccl: resurrect changefeed benchmark r=mrtracy a=danhhz

    name                           time/op
    ChangefeedTicks/InitialScan-8    12.3ms ± 3%
    ChangefeedTicks/SteadyState-8    52.3ms ± 3%

    name                           speed
    ChangefeedTicks/InitialScan-8  11.6MB/s ± 3%
    ChangefeedTicks/SteadyState-8  2.73MB/s ± 3%

    name                           alloc/op
    ChangefeedTicks/InitialScan-8    2.08MB ± 0%
    ChangefeedTicks/SteadyState-8    5.37MB ± 0%

    name                           allocs/op
    ChangefeedTicks/InitialScan-8     35.1k ± 0%
    ChangefeedTicks/SteadyState-8     68.6k ± 0%

Release note: None

29470: roachtest: add acceptance/version-upgrade r=nvanbenschoten a=petermattis

Move the version-upgrade acceptance test to a new
acceptance/version-upgrade roachtest.

See #29151

Release note: None

29511: roachtest: relax space reclamation in drop test r=petermattis a=tschottdorf

We know it fails; we are not looking into it right now due to other priorities.
This should be investigated and fixed in the course of #29290.

Closes #29232.
Closes #29327.

Release note: None

Co-authored-by: Daniel Harrison <[email protected]>
Co-authored-by: Peter Mattis <[email protected]>
Co-authored-by: Tobias Schottdorf <[email protected]>
@craig
Copy link
Contributor

craig bot commented Sep 4, 2018

Build succeeded

@craig craig bot merged commit d4b076b into cockroachdb:master Sep 4, 2018
@danhhz danhhz deleted the cdc_bench branch September 4, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants