release-2.1: server: deflake TestRapidRestarts #29259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In go1.10 and earlier, it was not safe to call `http.ServeMux.ServeHTTP` concurrently with `http.ServeMux.Handle`. (This is fixed in go1.11). In the interim, provide our own safeServeMux wrapper that provides proper locking. Fixes cockroachdb#29227 Release note: None
|
This change is |
|
LGTM |
|
bors r=benesch |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2018
29259: release-2.1: server: deflake TestRapidRestarts r=benesch a=petermattis Backport 1/1 commits from #29230. /cc @cockroachdb/release --- In go1.10 and earlier, it was not safe to call `http.ServeMux.ServeHTTP` concurrently with `http.ServeMux.Handle`. (This is fixed in go1.11). In the interim, provide our own safeServeMux wrapper that provides proper locking. Fixes #29227 Release note: None Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #29230.
/cc @cockroachdb/release
In go1.10 and earlier, it was not safe to call
http.ServeMux.ServeHTTPconcurrently with
http.ServeMux.Handle. (This is fixed in go1.11). Inthe interim, provide our own safeServeMux wrapper that provides proper
locking.
Fixes #29227
Release note: None