server: deflake TestRapidRestarts #29230
Merged
+90
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
TODO: This deserves a more dedicate test as I haven't been able to get |
benesch
approved these changes
Aug 29, 2018
petermattis
force-pushed
the
pmattis/deflake-test-rapid-restarts
branch
from
4650cd2 to
ac5957b
Compare
|
Added a dedicated test which fails reliably with bors r=benesch |
In go1.10 and earlier, it was not safe to call `http.ServeMux.ServeHTTP` concurrently with `http.ServeMux.Handle`. (This is fixed in go1.11). In the interim, provide our own safeServeMux wrapper that provides proper locking. Fixes cockroachdb#29227 Release note: None
petermattis
force-pushed
the
pmattis/deflake-test-rapid-restarts
branch
from
ac5957b to
f932530
Compare
Canceled |
|
bors r=benesch |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2018
29230: server: deflake TestRapidRestarts r=benesch a=petermattis In go1.10 and earlier, it was not safe to call `http.ServeMux.ServeHTTP` concurrently with `http.ServeMux.Handle`. (This is fixed in go1.11). In the interim, provide our own safeServeMux wrapper that provides proper locking. Fixes #29227 Release note: None 29236: Revert "storage: enable the merge queue by default" r=tschottdorf a=benesch This reverts commit 98ca1d0. The merge queue will be reenabled once flaky tests are fixed. To reviewers: I'd much prefer to merge #29235. But if that gets stuck in code review or the flakiness reaches a breaking point, feel free to merge this instead. Co-authored-by: Peter Mattis <[email protected]> Co-authored-by: Nikhil Benesch <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2018
29259: release-2.1: server: deflake TestRapidRestarts r=benesch a=petermattis Backport 1/1 commits from #29230. /cc @cockroachdb/release --- In go1.10 and earlier, it was not safe to call `http.ServeMux.ServeHTTP` concurrently with `http.ServeMux.Handle`. (This is fixed in go1.11). In the interim, provide our own safeServeMux wrapper that provides proper locking. Fixes #29227 Release note: None Co-authored-by: Peter Mattis <[email protected]>
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this pull request
Jul 23, 2020
`safeServeMux` was a wrapper to provide proper locking around `http.ServeMux` because in go1.10 and below, calls to `Handle` and `ServeHTTP` could race with each other. We don't need it anymore, see cockroachdb#29230. Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this pull request
Jul 24, 2020
`safeServeMux` was a wrapper to provide proper locking around `http.ServeMux` because in go1.10 and below, calls to `Handle` and `ServeHTTP` could race with each other. We don't need it anymore, see cockroachdb#29230. Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this pull request
Aug 13, 2020
`safeServeMux` was a wrapper to provide proper locking around `http.ServeMux` because in go1.10 and below, calls to `Handle` and `ServeHTTP` could race with each other. We don't need it anymore, see cockroachdb#29230. Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this pull request
Aug 26, 2020
`safeServeMux` was a wrapper to provide proper locking around `http.ServeMux` because in go1.10 and below, calls to `Handle` and `ServeHTTP` could race with each other. We don't need it anymore, see cockroachdb#29230. Release note: None
dhartunian
pushed a commit
to dhartunian/cockroach
that referenced
this pull request
Sep 22, 2020
`safeServeMux` was a wrapper to provide proper locking around `http.ServeMux` because in go1.10 and below, calls to `Handle` and `ServeHTTP` could race with each other. We don't need it anymore, see cockroachdb#29230. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go1.10 and earlier, it was not safe to call
http.ServeMux.ServeHTTPconcurrently with
http.ServeMux.Handle. (This is fixed in go1.11). Inthe interim, provide our own safeServeMux wrapper that provides proper
locking.
Fixes #29227
Release note: None