ui: allow long table rows to wrap #29206
Conversation
|
This change is |
There was a problem hiding this comment.
Any chance of this having unintended consequences? I agree that it's not a property you want on your base table, but have we already depended on it elsewhere?
I'm gonna go ahead and approve it, just be on guard in the next few days in case something gets screwed up on one of our other tables.
|
Thanks to both of you for being on the lookout for other ramifications. @vilterp I suspect that the version not wrapping is simply an artifact of changing the available space due to the address wrapping change, but we'd need to dig into it to be more specific. In any case, since the version column in released versions is quite short, this seems like a reasonable tradeoff. bors r+ |
|
bors r- |
Canceled |
Fixes: cockroachdb#29132 Release note (admin ui change): Allow long table rows to wrap, if necessary.
couchand
force-pushed
the
fix/wrap-long-lines
branch
from
b2f38ad to
a004ddb
Compare
|
bors r+ |
29206: ui: allow long table rows to wrap r=couchand a=couchand Fixes: #29132 Release note (admin ui change): Allow long table rows to wrap, if necessary. Before: <img width="1351" alt="screen shot 2018-08-27 at 12 19 04 pm" src="https://user-images.githubusercontent.com/7085343/44674574-8e0a8000-a9f3-11e8-8b2a-72358f65c098.png"> After: <img width="1159" alt="screen shot 2018-08-28 at 3 30 49 pm" src="https://user-images.githubusercontent.com/793969/44746086-67be1080-aad7-11e8-8616-158de5354fe1.png"> 29402: changefeedccl,jobspb: select initial scan timestamp on gateway r=mrtracy a=danhhz Fixes a buglet introduced in #28984 where each node in a distsql changefeed flow would pick its own timestamp to do the initial scan at. I thought I got all the backward-incompatible changes out of the way with #27996 but I didn't forsee this one. While I'm making a backward-incompatible change, switch targets from a `id->string` map to an `id->proto` map for future expansion. Row and partition watches, for example, will need this. Release note (backward-incompatible change): CHANGEFEEDs created with previous betas and alphas will not work with this version. Co-authored-by: Andrew Couch <[email protected]> Co-authored-by: Daniel Harrison <[email protected]>
Build succeeded |
|
Just noticed one: made the logs a bit harder to read since the time zones wrap.
Sigh. Probably just best to add a nowrap to that column. |
Fixes: #29132
Release note (admin ui change): Allow long table rows to wrap, if necessary.
Before:
After:
