Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Events page doesn't wrap the Event text, hiding the timestamps way off the page #29132

Closed
a-robinson opened this issue Aug 27, 2018 · 0 comments
Closed

ui: Events page doesn't wrap the Event text, hiding the timestamps way off the page #29132

a-robinson opened this issue Aug 27, 2018 · 0 comments
Assignees
@couchand
Labels
A-webui-layout-and-style C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Milestone
2.1

Comments

@a-robinson
Copy link
Contributor

I'd expect the timestamps to always be visible on the page without horizontal scrolling, but instead:

screen shot 2018-08-27 at 12 18 46 pm

screen shot 2018-08-27 at 12 19 04 pm

Check out https://adriatic.crdb.io:8080/#/events for a live example.
@a-robinson a-robinson added the A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. label Aug 27, 2018
@a-robinson a-robinson added this to the 2.1 milestone Aug 27, 2018
@couchand couchand added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-webui-layout-and-style and removed A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. labels Aug 28, 2018
@couchand couchand self-assigned this Aug 28, 2018
@couchand couchand mentioned this issue Aug 28, 2018
Merged
couchand added a commit to couchand/cockroach that referenced this issue Sep 4, 2018
@couchand
ui: allow long table rows to wrap
a004ddb 
Fixes: cockroachdb#29132
Release note (admin ui change): Allow long table rows to wrap,
if necessary.
craig bot pushed a commit that referenced this issue Sep 4, 2018
@couchand @danhhz
Merge #29206 #29402
07ebdf1 
29206: ui: allow long table rows to wrap r=couchand a=couchand

Fixes: #29132

Release note (admin ui change): Allow long table rows to wrap, if necessary.

Before:
<img width="1351" alt="screen shot 2018-08-27 at 12 19 04 pm" src="https://user-images.githubusercontent.com/7085343/44674574-8e0a8000-a9f3-11e8-8b2a-72358f65c098.png">

After:
<img width="1159" alt="screen shot 2018-08-28 at 3 30 49 pm" src="https://user-images.githubusercontent.com/793969/44746086-67be1080-aad7-11e8-8616-158de5354fe1.png">


29402: changefeedccl,jobspb: select initial scan timestamp on gateway r=mrtracy a=danhhz

Fixes a buglet introduced in #28984 where each node in a distsql
changefeed flow would pick its own timestamp to do the initial scan at.

I thought I got all the backward-incompatible changes out of the way
with #27996 but I didn't forsee this one. While I'm making a
backward-incompatible change, switch targets from a `id->string` map to
an `id->proto` map for future expansion. Row and partition watches, for
example, will need this.

Release note (backward-incompatible change): CHANGEFEEDs created with
previous betas and alphas will not work with this version.

Co-authored-by: Andrew Couch <[email protected]>
Co-authored-by: Daniel Harrison <[email protected]>
@craig craig bot closed this as completed in #29206 Sep 4, 2018
couchand added a commit to couchand/cockroach that referenced this issue Sep 4, 2018
@couchand
ui: allow long table rows to wrap
a7fbde6 
Fixes: cockroachdb#29132
Release note (admin ui change): Allow long table rows to wrap,
if necessary.
@couchand couchand mentioned this issue Sep 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@couchand couchand

Labels
A-webui-layout-and-style C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@couchand @a-robinson