build: check out submodules before building UI protobufs #28627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
benesch
force-pushed
the
uijs-submodules
branch
2 times, most recently
from
80fc651 to
8e075c4
Compare
|
Ping! |
|
Testing now. |
|
You bet! Thanks for the report. |
|
LGTM, ship it! |
Building UI protobufs indirectly requires that submodules have been checked out, as the Raft protobuf lives in the vendor submodule. Fix cockroachdb#28593. Release note: None
benesch
force-pushed
the
uijs-submodules
branch
from
8e075c4 to
c34d453
Compare
|
bors r=jordanlewis,rolandcrosby |
craig bot
pushed a commit
that referenced
this pull request
Aug 22, 2018
28627: build: check out submodules before building UI protobufs r=jordanlewis,rolandcrosby a=benesch Building UI protobufs indirectly requires that submodules have been checked out, as the Raft protobuf lives in the vendor submodule. Fix #28593. Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Aug 28, 2018
29124: backport-2.1: build: check out submodules before building UI protobufs r=rolandcrosby a=benesch Backport 1/1 commits from #28627. /cc @cockroachdb/release --- Building UI protobufs indirectly requires that submodules have been checked out, as the Raft protobuf lives in the vendor submodule. Fix #28593. Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building UI protobufs indirectly requires that submodules have been
checked out, as the Raft protobuf lives in the vendor submodule.
Fix #28593.
Release note: None