build: CONTRIBUTING.md instructions don't work for make build
#28593
Assignees
Comments
|
Thanks for catching this, @rolandcrosby! |
benesch
added a commit
to benesch/cockroach
that referenced
this issue
Aug 22, 2018
Building UI protobufs indirectly requires that submodules have been checked out, as the Raft protobuf lives in the vendor submodule. Fix cockroachdb#28593. Release note: None
craig bot
pushed a commit
that referenced
this issue
Aug 22, 2018
28627: build: check out submodules before building UI protobufs r=jordanlewis,rolandcrosby a=benesch Building UI protobufs indirectly requires that submodules have been checked out, as the Raft protobuf lives in the vendor submodule. Fix #28593. Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
benesch
added a commit
to benesch/cockroach
that referenced
this issue
Aug 27, 2018
Building UI protobufs indirectly requires that submodules have been checked out, as the Raft protobuf lives in the vendor submodule. Fix cockroachdb#28593. Release note: None
craig bot
pushed a commit
that referenced
this issue
Aug 28, 2018
29124: backport-2.1: build: check out submodules before building UI protobufs r=rolandcrosby a=benesch Backport 1/1 commits from #28627. /cc @cockroachdb/release --- Building UI protobufs indirectly requires that submodules have been checked out, as the Raft protobuf lives in the vendor submodule. Fix #28593. Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried to follow the instructions in CONTRIBUTING.md to build the latest master branch (bf3e90d) on my Mac, but running
make buildin a fresh checkout of the cockroach repo didn't work. Make output is here, generated by runningmake --debug build 2>&1 | tee build.log.I was able to get Cockroach to build successfully after making a fresh checkout and manually running
git submodule update --init --recursivebefore runningmake build, but I'm not sure why I had to do that. From the Make output, it looks like thebin/.submodules-initializedMake target was hit at some point anyway. Maybe there's some other target that needs submodules to be initialized, but that doesn't declare that dependency?The text was updated successfully, but these errors were encountered: