distsql: do not plan against unhealthy nodes #26950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Review status: Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
A bug was introduced in 0cd1da0 which allows table readers to be planned on unhealthy or incompatible nodes for LIMIT queries. They should use the gateway node instead. This was causing a panic in execution because the node was not in the nodeAddresses map. Fixes cockroachdb#26140 Release note (bug fix): Fixed 'node not in nodeAddresses map' panic, which could occur when distributed LIMIT queries were run on a cluster with at least one unhealthy node.
solongordon
force-pushed
the
fix-get-node-id
branch
from
32e169a to
626b72d
Compare
|
Updated the commit message to reflect that this bug only affects LIMIT queries. |
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 25, 2018
26950: distsql: do not plan against unhealthy nodes r=solongordon a=solongordon A bug was introduced in 0cd1da0 which allows table readers to be planned on unhealthy or incompatible nodes for LIMIT queries. They should use the gateway node instead. This was causing a panic in execution because the node was not in the nodeAddresses map. Fixes #26140 Release note (bug fix): Fixed 'node not in nodeAddresses map' panic, which could occur when distributed queries were run on a cluster with at least one unhealthy node. Co-authored-by: Solon Gordon <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 25, 2018
26953: release-2.0: distsql: do not plan against unhealthy nodes r=solongordon a=solongordon Backport 1/1 commits from #26950. /cc @cockroachdb/release --- A bug was introduced in 0cd1da0 which allows table readers to be planned on unhealthy or incompatible nodes for LIMIT queries. They should use the gateway node instead. This was causing a panic in execution because the node was not in the nodeAddresses map. Fixes #26140 Release note (bug fix): Fixed 'node not in nodeAddresses map' panic, which could occur when distributed queries were run on a cluster with at least one unhealthy node. Co-authored-by: Solon Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in 0cd1da0 which allows table readers to be planned
on unhealthy or incompatible nodes for LIMIT queries. They should use
the gateway node instead. This was causing a panic in execution because
the node was not in the nodeAddresses map.
Fixes #26140
Release note (bug fix): Fixed 'node not in nodeAddresses map' panic,
which could occur when distributed queries were run on a cluster with at
least one unhealthy node.