Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: start net/trace span in ChildSpan #16882

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Conversation

tbg
Copy link
Member

@tbg tbg commented Jul 6, 2017

Fixes #16881.

@tbg tbg requested a review from RaduBerinde July 6, 2017 15:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde
Copy link
Member

LGTM, thanks for the fix!

@RaduBerinde
Copy link
Member

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


pkg/util/tracing/tracer.go, line 347 at r1 (raw file):

	}

	if pSpan.netTr != nil {

[nit] conceptually, this belongs right after the shadowTr check (they're both "backends" in a way)


Comments from Reviewable

@RaduBerinde
Copy link
Member

pkg/util/tracing/tracer.go, line 347 at r1 (raw file):

Previously, RaduBerinde wrote…

[nit] conceptually, this belongs right after the shadowTr check (they're both "backends" in a way)

ah but I see StartSpan does the same, so disregard


Comments from Reviewable

@tbg tbg merged commit b86de26 into cockroachdb:master Jul 6, 2017
@tbg tbg deleted the child-span branch July 6, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants