Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: ChildSpan breaks /debug/requests #16881

Closed
tbg opened this issue Jul 6, 2017 · 1 comment
Closed

tracing: ChildSpan breaks /debug/requests #16881

tbg opened this issue Jul 6, 2017 · 1 comment
Assignees
@tbg

Comments

@tbg
Copy link
Member

tbg commented Jul 6, 2017

Set up a net/trace tracked span, and from it make a ChildSpan:

ctx, span := tracing.ChildSpan(ctx, "SECRET")
defer tracing.FinishSpan(span)

The ChildSpan will not be net/trace tracked, which is wrong.
@tbg tbg assigned andreimatei and tbg and unassigned andreimatei Jul 6, 2017
@tbg
Copy link
Member Author

tbg commented Jul 6, 2017

I'll fix, @RaduBerinde told me what to do.

@tbg tbg mentioned this issue Jul 6, 2017
Merged
tbg added a commit to tbg/cockroach that referenced this issue Jul 6, 2017
@tbg
tracing: start net/trace span in ChildSpan
a64b86b 
Fixes cockroachdb#16881.
@tbg tbg closed this as completed in #16882 Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreimatei @tbg