Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.3: roachtest: disable rate limiters in mixedversion #137528

Merged
merged 2 commits into from
Dec 16, 2024
Merged

release-24.3: roachtest: disable rate limiters in mixedversion #137528

merged 2 commits into from
Dec 16, 2024

Conversation

DarrylWong
Copy link
Contributor

@DarrylWong DarrylWong commented Dec 16, 2024 •
edited
Loading

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release Justification: test only change

@DarrylWong
roachtest: disable rate limiters in mixedversion
93078f7 
This change adds a step for separate process deployments
to disable both the KV and tenant rate limiter. The KV rate
limiter is disabled by granting the tenant capability:
`exempt_from_rate_limiting`. The tenant rate limiter cannot
be disabled outright, so instead the tenant is given arbritrarily
high limits. This should unblock separate process deployment tests.
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Dec 16, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 16, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DarrylWong
roachtest: use updated update_tenant_resource_limits signature in 24.…
db086f2 
…2.1+

The function signature of update_tenant_resource_limits was changed
in v24.2.1 to deprecate the args "as_of" and "as_of_consumed_tokens".
Since serverless currently only uses the `tenant_id` overload and
not the `tenant_name` overload like we do in mixedversion, the args
were removed completely from the latter.

This breaks backwards compatibility so this change selectively omits
the removed args if the version is 24.2.1+.
@DarrylWong DarrylWong marked this pull request as ready for review December 16, 2024 17:10
@DarrylWong DarrylWong requested a review from a team as a code owner December 16, 2024 17:10
@DarrylWong DarrylWong requested review from shailendra-patel and csgourav and removed request for a team December 16, 2024 17:10
@srosenberg srosenberg self-requested a review December 16, 2024 17:18
@DarrylWong DarrylWong merged commit 5166a1b into cockroachdb:release-24.3 Dec 16, 2024
20 of 21 checks passed
This was referenced Dec 17, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenberg srosenberg srosenberg approved these changes

@shailendra-patel shailendra-patel Awaiting requested review from shailendra-patel shailendra-patel is a code owner automatically assigned from cockroachdb/test-eng

@csgourav csgourav Awaiting requested review from csgourav csgourav is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarrylWong @cockroach-teamcity @srosenberg