roachtest: use updated update_tenant_resource_limits signature in 24.2.1+ #137137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DarrylWong
force-pushed
the
fix-tenant-limit-sql
branch
3 times, most recently
from
55fcf6b to
e8064f2
Compare
|
Tested by running |
DarrylWong
changed the title
…2.1+ The function signature of update_tenant_resource_limits was changed in v24.2.1 to deprecate the args "as_of" and "as_of_consumed_tokens". Since serverless currently only uses the `tenant_id` overload and not the `tenant_name` overload like we do in mixedversion, the args were removed completely from the latter. This breaks backwards compatibility so this change selectively omits the removed args if the version is 24.2.1+.
DarrylWong
force-pushed
the
fix-tenant-limit-sql
branch
from
e8064f2 to
e439d73
Compare
DarrylWong
requested review from
golgeek and
csgourav
and removed request for
a team
srosenberg
approved these changes
Dec 10, 2024
|
TFTR! bors r=srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function signature of update_tenant_resource_limits was changed in v24.2.1 to deprecate the args "as_of" and "as_of_consumed_tokens". Since serverless currently only uses the
tenant_idoverload and not thetenant_nameoverload like we do in mixedversion, the args were removed completely from the latter.This breaks backwards compatibility so this change selectively omits the removed args if the version is 24.2.1+.
Fixes: none
Epic: none
Release note: none