jobspb: mark ResolvedSpan_BoundaryType as SafeValue #137375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyyang890
requested review from
rharding6373,
a team and
xinhaoz
and removed request for
a team and
xinhaoz
andyyang890
requested review from
kyle-a-wong and
kev-cao
and removed request for
a team
|
This change is |
andyyang890
added
backport-23.2.x
rharding6373
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @kev-cao and @kyle-a-wong)
This patch marks `jobspb.ResolvedSpan_BoundaryType` as a SafeValue so that it won't be redacted in the logs. Release note: None
andyyang890
force-pushed
the
20241212-unredact-boundary-type
branch
from
8ccc1ce to
2e66bb2
Compare
|
TFTR! bors r=rharding6373 |
This was referenced Dec 13, 2024
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 2e66bb2 to blathers/backport-release-23.2-137375: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch marks
jobspb.ResolvedSpan_BoundaryTypeas a SafeValueso that it won't be redacted in the logs.
Informs #128597
Release note: None