Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less redaction for Changefeed log messages #128597

Open
rharding6373 opened this issue Aug 8, 2024 · 2 comments
Open

Less redaction for Changefeed log messages #128597

rharding6373 opened this issue Aug 8, 2024 · 2 comments
Labels
A-cdc Change Data Capture C-wishlist A wishlist feature. O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-3 Issues/test failures with no fix SLA T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented Aug 8, 2024

One of our supportability problems at Cockroach Labs is missing data often stemming from overly redacting our logs. Over-redaction makes troubleshooting issues difficult for our support engineers. CockroachDB should only redact the necessary information considered sensitive by our ICPs (e.g., key:value data).

This ticket tracks improving the default redaction behavior for Changefeed errors.

Jira issue: CRDB-38330

Epic CRDB-32401

@rharding6373 rharding6373 added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 8, 2024
Copy link

blathers-crl bot commented Aug 8, 2024

Hi @rharding6373, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rharding6373 rharding6373 added the O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs label Aug 8, 2024
Copy link

blathers-crl bot commented Aug 9, 2024

cc @cockroachdb/cdc

@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Aug 9, 2024
@rharding6373 rharding6373 added C-wishlist A wishlist feature. P-3 Issues/test failures with no fix SLA and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Aug 20, 2024
craig bot pushed a commit that referenced this issue Dec 13, 2024
137375: jobspb: mark ResolvedSpan_BoundaryType as SafeValue r=rharding6373 a=andyyang890

This patch marks `jobspb.ResolvedSpan_BoundaryType` as a SafeValue
so that it won't be redacted in the logs.

Informs #128597

Release note: None

137410: kvserver: deflake TestReplicaCircuitBreaker_RangeFeed r=iskettaneh a=iskettaneh

This commit extends the timeout for the function tc.UntripsSoon(). I noticed that with leader leases, this function could take a little longer than before to finish successfully. Especially if we just restart the server.

Fixes: #137372

Release note: None

Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Ibrahim Kettaneh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-wishlist A wishlist feature. O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-3 Issues/test failures with no fix SLA T-cdc
Projects
None yet
Development

No branches or pull requests

1 participant