Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: make disk bandwidth test manual only #137288

Merged

Conversation

aadityasondhi
Copy link
Collaborator

This test is a little too noisy until we make further improvements to the disk bandwidth limiter.

Fixes: #136064.

Release note: None

This test is a little too noisy until we make further improvements to
the disk bandwidth limiter.

Fixes: cockroachdb#136064.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aadityasondhi
Copy link
Collaborator Author

Reason for RC backport is #136950

Copy link
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aadityasondhi
Copy link
Collaborator Author

TFTRs!

bors r+

@craig craig bot merged commit 43fe07f into cockroachdb:master Dec 12, 2024
22 checks passed
Copy link

blathers-crl bot commented Dec 12, 2024

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #136064: branch-release-24.3.1-rc.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link

blathers-crl bot commented Dec 12, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 9952005 to blathers/backport-release-24.3.1-rc-137288: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.3.1-rc failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: admission-control/disk-bandwidth-limiter failed
4 participants