-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: admission-control/disk-bandwidth-limiter failed #136064
Comments
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ f717f6bd218121bb5e3376af658545f6bff30c22:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ 67caf19d3998bb3ca1ada7e3c14486d505b68012:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
Known limitation being fixed in #133310 |
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ bcc993d796d03664604bf695e38fd5644d0bc952:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ bcc993d796d03664604bf695e38fd5644d0bc952:
Parameters:
Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ b3fec61ca90095c664f6432af864f18e9946f8bb:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ 44de2d379610067e14a7ebfbc92e64311f13a232:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ 21d1123dce5401b1ec580d4156db5db075074506:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters |
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ 9744e5f1676a752d5b200fe7bce84ca8b44afca0:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ d7ea85402dc35e36c6cc35520fa91f25fd5c999d:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ de3b1220f5c71ac966561505c1b379060fa1407f:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ a3957e4bee7b2b77632e811203a86ecaa95422ca:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ d18eb683b2759fd8814dacf0baa913f596074a17:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ e8ee6f574ddf1fce1a4cb53f392c5a9baf633b76:
Parameters:
Help
See: roachtest README See: How To Investigate (internal) Grafana is not yet available for aws clusters Same failure on other branches
|
135924: sql: label latency histograms with statement fingerprint r=MattWhelan a=MattWhelan Previously, we collected a single histogram for all statements. While this sort of metric may be useful in overall database operations, application developers need more detail, to know how their code changes impact their query latencies. By switching to HistogramVec, we can now offer per-statement-fingerprint latency metrics. This feature is disabled by default. To know whether its safe to enable, we also track a cardinality estimate of the unique statement fingerprints that we see. TREQ: https://cockroachlabs.atlassian.net/browse/TREQ-703 Epic: none Release note (ops change): Introduces a new `sql.exec.latency.detail` histogram metric. This metric is labeled with its statement fingerprint. Enable this feature using the `sql.stats.detailed_latency_metrics.enabled` application setting. The `sql.query.unique.count` metric is a new count metric that estimates the cardinality of the set of all statement fingerprints. For most workloads, this ranges from dozens to hundreds. For workloads with over a couple thousand fingerprints, we advise caution in enabling `sql.stats.detailed_latency_metrics.enabled`. Benchmark results: ``` # Baseline (master branch) _elapsed_______tpmC____efc__avg(ms)__p50(ms)__p90(ms)__p95(ms)__p99(ms)_pMax(ms) 1800.0s 6314.1 98.2% 31.2 21.0 52.4 88.1 209.7 570.4 # PR, setting disabled _elapsed_______tpmC____efc__avg(ms)__p50(ms)__p90(ms)__p95(ms)__p99(ms)_pMax(ms) 1800.0s 6315.6 98.2% 24.2 19.9 33.6 48.2 117.4 805.3 # PR, setting enabled _elapsed_______tpmC____efc__avg(ms)__p50(ms)__p90(ms)__p95(ms)__p99(ms)_pMax(ms) 1800.0s 6309.1 98.1% 24.2 19.9 33.6 48.2 113.2 671.1 ``` 136995: kvserver/rangefeed: metamorphically enable RangefeedUseBufferedSender r=stevendanna a=wenyihu6 **kvserver/rangefeed: rename .buffered_stream_sender. to .buffered_sender.** This patch renames kv.rangefeed.buffered_stream_sender.enabled to kv.rangefeed.buffered_sender.enabled to align with variable and struct names better. Epic: none Release: none --- **kvserver/rangefeed: metamorphically enable RangefeedUseBufferedSender** This patch metamorphically enables the cluster setting RangefeedUseBufferedSender. Release note: none Part of: #135332 137288: roachtest: make disk bandwidth test manual only r=aadityasondhi a=aadityasondhi This test is a little too noisy until we make further improvements to the disk bandwidth limiter. Fixes: #136064. Release note: None Co-authored-by: Matt Whelan <[email protected]> Co-authored-by: Wenyi Hu <[email protected]> Co-authored-by: Aaditya Sondhi <[email protected]>
Based on the specified backports for linked PR #137288, I applied the following new label(s) to this issue: branch-release-24.3.1-rc. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This test is a little too noisy until we make further improvements to the disk bandwidth limiter. Fixes: cockroachdb#136064. Release note: None
roachtest.admission-control/disk-bandwidth-limiter failed with artifacts on master @ cea3ff5562160a3bf2802da052da2aaa40e1ccc1:
Parameters:
arch=amd64
cloud=aws
coverageBuild=false
cpu=8
encrypted=false
fs=ext4
localSSD=true
metamorphicLeases=default
runtimeAssertionsBuild=false
ssd=0
Help
See: roachtest README
See: How To Investigate (internal)
Grafana is not yet available for aws clusters
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-44847
The text was updated successfully, but these errors were encountered: