Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: TEAMS: ping kv-triage for unittest failures #136681

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 4, 2024

Backport 4/4 commits from #136571 on behalf of @tbg.

/cc @cockroachdb/release


Currently unit test nightlies ping (at)cockroachdb/kv, our main handle.
This is not a team we'd like people to just leave to avoid notifications.
Github doesn't seem to offer a way to opt out of notifications for a team
one is on, besides, there are useful notifications going to that handle.

Our triage process is robust without these mentions. They can go to
(at)cockroachdb/kv-notifications for those inclined to consume a
firehose.

This change frees up our main alias (at)cockroachdb/kv for more
meaningful notifications.

Epic: none


Release justification: triage QOL improvement

tbg added 4 commits December 3, 2024 12:14
If a team defines one or multiple aliases for "unittest" purposes,
CI/nightly issue posters now mention this one instead of the team's
main alias.
Our triage process is robust without these mentions. They can go to
(at)cockroachdb/kv-notifications for those inclined to consume a
firehose.

This change frees up our main alias (at)cockroachdb/kv for more
meaningful notifications.
@blathers-crl blathers-crl bot requested review from a team as code owners December 4, 2024 12:08
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 4, 2024
@blathers-crl blathers-crl bot requested review from herkolategan and srosenberg and removed request for a team December 4, 2024 12:08
Copy link
Author

blathers-crl bot commented Dec 4, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 4, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg merged commit e15d9e3 into release-24.2 Dec 5, 2024
19 of 20 checks passed
@tbg tbg deleted the blathers/backport-release-24.2-136571 branch December 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants