TEAMS: ping kv-triage for unittest failures #136571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a team defines one or multiple aliases for "unittest" purposes, CI/nightly issue posters now mention this one instead of the team's main alias.
Our triage process is robust without these mentions. They can go to (at)cockroachdb/kv-notifications for those inclined to consume a firehose. This change frees up our main alias (at)cockroachdb/kv for more meaningful notifications.
tbg
requested review from
nameisbhaskar,
DarrylWong and
arulajmani
and removed request for
a team
|
This change is |
arulajmani
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @nameisbhaskar)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
136538: sql/stats: skip over histogram buckets for dropped enum values r=yuzefovich a=michae2 While decoding histogram upper bounds, if we discover that a physical representation of an enum value cannot be found in the enum type, assume that the value has been dropped and skip over the bucket. This allows us to continue using the most recent statistics after altering an enum type. Fixes: #67050 Release note (bug fix): Fix a bug which causes the optimizer to use stale table statistics after altering an enum type used in the table. 136571: TEAMS: ping kv-triage for unittest failures r=tbg a=tbg Currently unit test nightlies ping (at)cockroachdb/kv, our main handle. This is not a team we'd like people to just leave to avoid notifications. Github doesn't seem to offer a way to opt out of notifications for a team one is on, besides, there are useful notifications going to that handle. Our triage process is robust without these mentions. They can go to (at)cockroachdb/kv-notifications for those inclined to consume a firehose. This change frees up our main alias (at)cockroachdb/kv for more meaningful notifications. 136605: kvserver: deflake TestStoreRangeMergeAbandonedFollowersAutomaticallyGarbageCollected r=arulajmani a=arulajmani Fixes #136597 Release note: None Co-authored-by: Michael Erickson <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Arul Ajmani <[email protected]>
|
bors r+ |
|
blathers backport 24.3 |
|
blathers backport 24.2 |
|
blathers backport 24.1 |
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently unit test nightlies ping (at)cockroachdb/kv, our main handle.
This is not a team we'd like people to just leave to avoid notifications.
Github doesn't seem to offer a way to opt out of notifications for a team
one is on, besides, there are useful notifications going to that handle.
Our triage process is robust without these mentions. They can go to
(at)cockroachdb/kv-notifications for those inclined to consume a
firehose.
This change frees up our main alias (at)cockroachdb/kv for more
meaningful notifications.
Epic: none