-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvcoord: disable deadlock/race for expiration leases TestProxyTracing #135858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arulajmani
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)
-- commits
line 2 at r1:
nit: "disable" (no caps) in PR titles.
iskettaneh
changed the title
kvcoord: Disable deadlock/race for expiration leases TestProxyTracing
kvcoord: disable deadlock/race for expiration leases TestProxyTracing
Nov 21, 2024
iskettaneh
force-pushed
the
DeflakeProxy2
branch
from
November 21, 2024 00:58
fcc254f
to
cad835e
Compare
TFTR bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
135858: kvcoord: disable deadlock/race for expiration leases TestProxyTracing r=iskettaneh a=iskettaneh This commit disables deadlock/race runs for TestProxyTracing when running with expiration leases. The main reason is that it consumes resources unnecessarily. References: #135493 Release note: None Co-authored-by: Ibrahim Kettaneh <[email protected]>
Build failed: |
This commit disables deadlock/race runs for TestProxyTracing when running with expiration leases. The main reason is that it consumes resources unnecessarily. References: cockroachdb#135493 Release note: None
iskettaneh
force-pushed
the
DeflakeProxy2
branch
from
November 21, 2024 01:08
cad835e
to
12db3e3
Compare
bors r+ |
iskettaneh
added
backport-24.1.x
Flags PRs that need to be backported to 24.1.
backport-24.2.x
Flags PRs that need to be backported to 24.2
backport-24.3.x
Flags PRs that need to be backported to 24.3
labels
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-24.1.x
Flags PRs that need to be backported to 24.1.
backport-24.2.x
Flags PRs that need to be backported to 24.2
backport-24.3.x
Flags PRs that need to be backported to 24.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables deadlock/race runs for TestProxyTracing when running with expiration leases. The main reason is that it consumes resources unnecessarily.
References: #135493
Release note: None