Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvcoord: disable deadlock/race for expiration leases TestProxyTracing #135858

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

iskettaneh
Copy link
Contributor

This commit disables deadlock/race runs for TestProxyTracing when running with expiration leases. The main reason is that it consumes resources unnecessarily.

References: #135493

Release note: None

@iskettaneh iskettaneh requested a review from a team as a code owner November 20, 2024 22:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)


-- commits line 2 at r1:
nit: "disable" (no caps) in PR titles.

@iskettaneh iskettaneh changed the title kvcoord: Disable deadlock/race for expiration leases TestProxyTracing kvcoord: disable deadlock/race for expiration leases TestProxyTracing Nov 21, 2024
@iskettaneh
Copy link
Contributor Author

TFTR

bors r+

craig bot pushed a commit that referenced this pull request Nov 21, 2024
135858: kvcoord: disable deadlock/race for expiration leases TestProxyTracing r=iskettaneh a=iskettaneh

This commit disables deadlock/race runs for TestProxyTracing when running with expiration leases. The main reason is that it consumes resources unnecessarily.

References: #135493

Release note: None

Co-authored-by: Ibrahim Kettaneh <[email protected]>
@craig
Copy link
Contributor

craig bot commented Nov 21, 2024

Build failed:

This commit disables deadlock/race runs for TestProxyTracing when
running with expiration leases. The main reason is that it consumes
resources unnecessarily.

References: cockroachdb#135493

Release note: None
@iskettaneh
Copy link
Contributor Author

bors r+

@craig craig bot merged commit 5c3cfd9 into cockroachdb:master Nov 21, 2024
22 of 23 checks passed
@iskettaneh iskettaneh added backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants