Skip to content

Commit

Permalink
kvcoord: Disable deadlock/race for expiration leases TestProxyTracing
Browse files Browse the repository at this point in the history
This commit disables deadlock/race runs for TestProxyTracing when
running with expiration leases. The main reason is that it consumes
resources unnecessarily.

References: #135493

Release note: None
  • Loading branch information
iskettaneh committed Nov 20, 2024
1 parent 7194126 commit fcc254f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/kv/kvclient/kvcoord/dist_sender_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4834,7 +4834,10 @@ func TestProxyTracing(t *testing.T) {
ctx := context.Background()

testutils.RunValues(t, "lease-type", roachpb.LeaseTypes(), func(t *testing.T, leaseType roachpb.LeaseType) {
if leaseType == roachpb.LeaseEpoch {
if leaseType == roachpb.LeaseExpiration {
skip.UnderRace(t, "too slow")
skip.UnderDeadlock(t, "too slow")
} else if leaseType == roachpb.LeaseEpoch {
// With epoch leases this test doesn't work reliably. It passes
// in cases where it should fail and fails in cases where it
// should pass.
Expand Down

0 comments on commit fcc254f

Please sign in to comment.