-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: opt: disallow non-standard NULL ordering with subqueries in test builds #135229
release-24.1: opt: disallow non-standard NULL ordering with subqueries in test builds #135229
Conversation
The optimizer does not correctly build `ORDER BY` expressions with non-standard `NULL` orderings when one or more of the ordering columns is a projection containing a subquery. This causes test-only assertions to fail in randomized tests. It is not yet known if there are any issues with the results of these queries in production builds where the test assertions are disabled. For now, we simply return an "unimplemented" error to silence the failures. Informs #129956 Release note: None
629bc1c
to
3d88753
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
Backporting to prevent creation of duplicates of #129956 on 24.1 branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @mgartner)
Backport 1/1 commits from #131254 on behalf of @mgartner.
/cc @cockroachdb/release
The optimizer does not correctly build
ORDER BY
expressions withnon-standard
NULL
orderings when one or more of the ordering columnsis a projection containing a subquery. This causes test-only assertions
to fail in randomized tests. It is not yet known if there are any issues
with the results of these queries in production builds where the test
assertions are disabled.
For now, we simply return an "unimplemented" error to silence the
failures.
Informs #129956
Release note: None
Release justification: Test-only change.