opt: disallow non-standard NULL ordering with subqueries in test builds #131254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DrewKimball
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
The optimizer does not correctly build `ORDER BY` expressions with non-standard `NULL` orderings when one or more of the ordering columns is a projection containing a subquery. This causes test-only assertions to fail in randomized tests. It is not yet known if there are any issues with the results of these queries in production builds where the test assertions are disabled. For now, we simply return an "unimplemented" error to silence the failures. Informs cockroachdb#129956 Release note: None
mgartner
force-pushed
the
129956-silence-failures
branch
from
34bdf73
to
fe771d0
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
|
blathers backport 24.2 |
This was referenced Oct 21, 2024
|
blathers backport 24.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizer does not correctly build
ORDER BYexpressions withnon-standard
NULLorderings when one or more of the ordering columnsis a projection containing a subquery. This causes test-only assertions
to fail in randomized tests. It is not yet known if there are any issues
with the results of these queries in production builds where the test
assertions are disabled.
For now, we simply return an "unimplemented" error to silence the
failures.
Informs #129956
Release note: None