roachtest: split perturbation/* tests #134886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the perturbation test used reflection to determine the set of spec options to use. This change allows each test to customize any options it needs. Epic: none Release note: None
This change makes the cluster settings a first class structure in the perturbation tests. This allows different tests to set the settings how they need when they start. Epic: none Release note: None
As part of the effort to make perturbation tests more first class and owned by separate teams, this commit moves them to their own directory. Epic: none Release note: None
andrewbaptist
requested review from
herkolategan and
vidit-bhat
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
Only the last 2 commits in this are new, the others are part of #134871. |
This commit splits all the individual perturbations into separate files. This will make it easier to find and update a perturbation. Epic: none Release note: None
andrewbaptist
force-pushed
the
2024-11-11-split-perturbation
branch
from
8a532e8 to
0cbc4e7
Compare
kvoli
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
I wasn't able to check over the split out files to see if there was any diff. Assuming this was purely mechanical, 
Reviewed 6 of 6 files at r3, 10 of 10 files at r4, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @vidit-bhat)
|
TFTR! Yes two purely mechanical changes. Since you also approved #134871 I'll bors this one and close that out. bors r=kvoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits all the individual perturbations into separate files. This will make it easier to find and update a perturbation.
Epic: none
Release note: None